Skip to content
This repository has been archived by the owner. It is now read-only.

8259061: C2: assert(found) failed: memory-writing node is not placed in its original loop or an ancestor of it #101

Closed
wants to merge 1 commit into from

Conversation

@robcasloz
Copy link

@robcasloz robcasloz commented Jan 11, 2021

Remove assertion that is too general, that is, it can fail on compilations where C2 generates correct code otherwise.

The assertion was introduced in JDK-8255763 to prevent potential miscompilations in the case of irreducible CFGs, and will be reconsidered in JDK-8258894 where the general case is addressed.

Tested by building (release and debug) on different platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259061: C2: assert(found) failed: memory-writing node is not placed in its original loop or an ancestor of it

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/101/head:pull/101
$ git checkout pull/101

…ced in its original loop or an ancestor of it

Remove assertion that is too general, that is, it can fail on compilations where
C2 generates correct code otherwise.
@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 11, 2021

/summary
Remove assertion that is too general, that is, it can fail on compilations where
C2 generates correct code otherwise.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 11, 2021

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@robcasloz Setting summary to:

Remove assertion that is too general, that is, it can fail on compilations where
C2 generates correct code otherwise.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@robcasloz The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@robcasloz robcasloz marked this pull request as ready for review Jan 11, 2021
@openjdk openjdk bot added the rfr label Jan 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 11, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

That's reasonable. Looks good to me!

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259061: C2: assert(found) failed: memory-writing node is not placed in its original loop or an ancestor of it

Remove assertion that is too general, that is, it can fail on compilations where
C2 generates correct code otherwise.

Reviewed-by: chagedorn, thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 793017d: 8259601: AArch64: Fix reinterpretX2D match rule issue
  • 15dd8f3: 8259275: JRuby crashes while resolving invokedynamic instruction
  • 1cf2378: 8259353: VectorReinterpretNode is incorrectly optimized out
  • 17b4db3: 8259636: Check for buffer backed by shared segment kicks in in unexpected places
  • 5f9cd72: 8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case
  • b03880e: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds
  • 8a81cf1: 8259298: broken link in Stream::toList spec
  • 67e1b63: 8259380: Correct pretouch chunk size to cap with actual page size
  • 28ff2de: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • a7e5da2: 8258384: AArch64: SVE verify_ptrue fails on some tests
  • ... and 3 more: https://git.openjdk.java.net/jdk16/compare/020ec8485251698d1187204ac13321f4726e45ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 11, 2021
@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 11, 2021

That's reasonable. Looks good to me!

Thanks for reviewing, Christian!

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me too.

@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 11, 2021

Looks good to me too.

Thanks, Tobias!

Copy link

@vnkozlov vnkozlov left a comment

Agree.

@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 12, 2021

Agree.

Thanks, Vladimir!

@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 13, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2021

@robcasloz
Your change (at version 1296329) is now ready to be sponsored by a Committer.

@robcasloz
Copy link
Author

@robcasloz robcasloz commented Jan 13, 2021

Thanks again for the reviews, please sponsor.

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jan 13, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2021

@TobiHartmann @robcasloz Since your change was applied there have been 13 commits pushed to the master branch:

  • 793017d: 8259601: AArch64: Fix reinterpretX2D match rule issue
  • 15dd8f3: 8259275: JRuby crashes while resolving invokedynamic instruction
  • 1cf2378: 8259353: VectorReinterpretNode is incorrectly optimized out
  • 17b4db3: 8259636: Check for buffer backed by shared segment kicks in in unexpected places
  • 5f9cd72: 8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case
  • b03880e: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds
  • 8a81cf1: 8259298: broken link in Stream::toList spec
  • 67e1b63: 8259380: Correct pretouch chunk size to cap with actual page size
  • 28ff2de: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • a7e5da2: 8258384: AArch64: SVE verify_ptrue fails on some tests
  • ... and 3 more: https://git.openjdk.java.net/jdk16/compare/020ec8485251698d1187204ac13321f4726e45ea...master

Your commit was automatically rebased without conflicts.

Pushed as commit 417e1d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants