Skip to content
This repository has been archived by the owner. It is now read-only.

8259634: MemorySegment::asByteBuffer does not respect spatial bounds #109

Closed
wants to merge 1 commit into from

Conversation

@mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jan 12, 2021

The byte buffers created from heap segments do not honor the javadoc - which says that the resulting buffer size should be equal to MemorySegment::byteSize, and that the buffer position should be zero.

The issue is that the NIO routine we have added to create heap buffers is using the wrong constructor, which doesn't do what we need. The fix is to simply use the proper, more complete constructor.

I've also re-enabled an unrelated test which was missing the @test annotation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259634: MemorySegment::asByteBuffer does not respect spatial bounds

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/109/head:pull/109
$ git checkout pull/109

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jan 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259634: MemorySegment::asByteBuffer does not respect spatial bounds

Reviewed-by: alanb, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 12, 2021
@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Jan 12, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@mcimadamore Since your change was applied there has been 1 commit pushed to the master branch:

  • 8a81cf1: 8259298: broken link in Stream::toList spec

Your commit was automatically rebased without conflicts.

Pushed as commit b03880e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants