Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case #112

Closed

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jan 12, 2021

This reverts commit 46c9a86.

The fix for 8245956 exposed a bug in the underlying URL API, regarding the encoding of non-ASCII characters in filenames.
The fix is reverted until the underlying problem can be addressed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/112/head:pull/112
$ git checkout pull/112

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label Jan 12, 2021
@jonathan-gibbons jonathan-gibbons changed the title Revert "8245956: JavaCompiler still uses File API instead of Path API in a specific case" JDK-8259645: Revert "8245956: JavaCompiler still uses File API instead of Path API in a specific case" Jan 12, 2021
@openjdk openjdk bot added the rfr label Jan 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Webrevs

Loading

@jonathan-gibbons jonathan-gibbons changed the title JDK-8259645: Revert "8245956: JavaCompiler still uses File API instead of Path API in a specific case" JDK-8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259645: Revert JDK-8245956 JavaCompiler still uses File API instead of Path API in a specific case

Reviewed-by: chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • b03880e: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds
  • 8a81cf1: 8259298: broken link in Stream::toList spec
  • 67e1b63: 8259380: Correct pretouch chunk size to cap with actual page size
  • 28ff2de: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • a7e5da2: 8258384: AArch64: SVE verify_ptrue fails on some tests
  • 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
  • d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
  • e05f36f: 8259043: More Zero architectures need linkage with libatomic
  • 020ec84: 8259429: Update reference to README.md
  • fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
  • ... and 35 more: https://git.openjdk.java.net/jdk16/compare/8da7c58016342e88e9f32ee23550a91b773001ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 12, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 12, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@jonathan-gibbons Since your change was applied there have been 45 commits pushed to the master branch:

  • b03880e: 8259634: MemorySegment::asByteBuffer does not respect spatial bounds
  • 8a81cf1: 8259298: broken link in Stream::toList spec
  • 67e1b63: 8259380: Correct pretouch chunk size to cap with actual page size
  • 28ff2de: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • a7e5da2: 8258384: AArch64: SVE verify_ptrue fails on some tests
  • 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
  • d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
  • e05f36f: 8259043: More Zero architectures need linkage with libatomic
  • 020ec84: 8259429: Update reference to README.md
  • fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
  • ... and 35 more: https://git.openjdk.java.net/jdk16/compare/8da7c58016342e88e9f32ee23550a91b773001ab...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5f9cd72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@jonathan-gibbons jonathan-gibbons deleted the revert-file branch Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants