8253505: JFR: onFlush invoked out of order with a sorted event stream

[egahlin]

Hi,

Could I have a review of a fix that makes sure EventStream::onFlush is always called after events in a segment has been pushed.

Testing jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253505: JFR: onFlush invoked out of order with a sorted event stream

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/116/head:pull/116
$ git checkout pull/116

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ca04766)
• 00: Full (32fc257)

[mgronlun]

Looks good.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253505: JFR: onFlush invoked out of order with a sorted event stream

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis
• 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
• 8abefde: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
• fb8ac24: 8259722: ProblemList two jdk/jfr/startupargs tests on Windows
• ac4cd2e: 8231461: static/instance overload leads to 'unexpected static method found in unbound lookup' when resolving method reference
• 42d2d6d: 8259063: Possible deadlock with vtable/itable creation vs concurrent class unloading
• 6bb6093: 8259657: typo in generated HELP page prevents localization
• 5567530: 8258272: LoadVectorMaskedNode can't be replaced by zero con
• a99df45: 8259560: Zero m68k: "static assertion failed: align" after JDK-8252049
• efc36be: 8258985: Parallel WeakProcessor may use too few threads
• ... and 31 more: https://git.openjdk.java.net/jdk16/compare/d5293067226011a96f97cd5e8efe0dd2dff521b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

@egahlin Since your change was applied there have been 41 commits pushed to the master branch:

• 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis
• 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
• 8abefde: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
• fb8ac24: 8259722: ProblemList two jdk/jfr/startupargs tests on Windows
• ac4cd2e: 8231461: static/instance overload leads to 'unexpected static method found in unbound lookup' when resolving method reference
• 42d2d6d: 8259063: Possible deadlock with vtable/itable creation vs concurrent class unloading
• 6bb6093: 8259657: typo in generated HELP page prevents localization
• 5567530: 8258272: LoadVectorMaskedNode can't be replaced by zero con
• a99df45: 8259560: Zero m68k: "static assertion failed: align" after JDK-8252049
• efc36be: 8258985: Parallel WeakProcessor may use too few threads
• ... and 31 more: https://git.openjdk.java.net/jdk16/compare/d5293067226011a96f97cd5e8efe0dd2dff521b2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4307fa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.