Skip to content
This repository has been archived by the owner. It is now read-only.

8259757: add a regression test for 8259353 and 8259601 #120

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jan 14, 2021

Hi all,

could you please review this small test-only patch which adds a regression test for 8259353 and 8259601?

testing:

  • test/hotspot/jtreg/compiler/vectorapi/Test8259353.java against jdk-16+26 (which doesn't have fixes) : failed, as expected
  • test/hotspot/jtreg/compiler/vectorapi/Test8259353.java multiple times against jdk-16+32 : passed

Thanks,
-- Igor

/contributor add @XiaohongGong
/contributor add @iignatev


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259757: add a regression test for 8259353 and 8259601

Reviewers

Contributors

  • Xiaohong Gong <xgong@openjdk.org>
  • Igor Ignatyev <iignatyev@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/120/head:pull/120
$ git checkout pull/120

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 14, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@iignatev
Contributor Xiaohong Gong <xgong@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@iignatev
Contributor Igor Ignatyev <iignatyev@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jan 14, 2021
@openjdk openjdk bot added the rfr label Jan 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 16, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259757: add a regression test for 8259353 and 8259601

Co-authored-by: Xiaohong Gong <xgong@openjdk.org>
Co-authored-by: Igor Ignatyev <iignatyev@openjdk.org>
Reviewed-by: kvn, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • 4307fa6: 8253505: JFR: onFlush invoked out of order with a sorted event stream
  • 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 16, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Jan 20, 2021

Thanks guys.

/integrate

@openjdk openjdk bot closed this Jan 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@iignatev Since your change was applied there have been 8 commits pushed to the master branch:

  • 0120510: 8259732: JDK 16 L10n resource file update - msg drop 10
  • f7b96d3: 8259796: timed CompletableFuture.get may swallow InterruptedException
  • bb0821e: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • cd25bf2: 8259574: SIGSEGV in BFSClosure::closure_impl
  • d5ca3b3: 8259641: C2: assert(early->dominates(LCA)) failed: early is high enough
  • e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • 4307fa6: 8253505: JFR: onFlush invoked out of order with a sorted event stream
  • 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis

Your commit was automatically rebased without conflicts.

Pushed as commit 0408b23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler integrated
3 participants