JDK-8259732: JDK 16 L10n resource file update - msg drop 10 #123
Conversation
|
@leohacker The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Since they're Unicode escape sequences in the l10n resource files, so I attached a human readable webrev, created by or review the changes from openjdk cr. |
@naotoj Would you have time to take a look at this change? Very appreciated! |
It may be removed in a future release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is to fix no newline at the end (unrelated to l10n changes). Do we need to change the copyright year for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was correcting the L217, changed {) -> {}. But 2 days ago, Jonathan Gibbons fixed it in another commit 6bb6093. I found his fix after running the merge. Looks both of us forgot to update the copyright year. Any suggestion?
doclet.help.systemProperties.body=\
The {0} page lists references to system properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe your PR still contains the fix to add the newline at the end of the file (at L518). So I think you can simply change the copyright year in standard.properties
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! Fixed the copyright year for this file.
@leohacker This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@leohacker Since your change was applied there have been 7 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 0120510. |
This is the changes for JDK 16 msg drop 10.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123
$ git checkout pull/123