Skip to content
This repository has been archived by the owner. It is now read-only.

8259574: SIGSEGV in BFSClosure::closure_impl #125

Closed
wants to merge 1 commit into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Jan 15, 2021

Greetings,

please help review this small adjustment to get the JFR Memory Leak Profiler working again.

Testing: jdk_jfr

Thanks
Markus


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/125/head:pull/125
$ git checkout pull/125

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2021

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Jan 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2021

Webrevs

Copy link
Member

@stefank stefank left a comment

The chains/ changes look good. I don't know why jfrEmergencyDump.cpp was changed, so that has not been reviewed by me.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259574: SIGSEGV in BFSClosure::closure_impl

Reviewed-by: stefank, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 15, 2021
@mgronlun
Copy link
Author

@mgronlun mgronlun commented Jan 15, 2021

@stefank thank you. The change to jfrEmergencyDump.cpp is done (and is also overdue) because in this case, it is the VMThread that crashes and attempts to issue the jfr emergency dump.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Jan 18, 2021

/integrate

@openjdk openjdk bot closed this Jan 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2021

@mgronlun Since your change was applied there have been 2 commits pushed to the master branch:

  • d5ca3b3: 8259641: C2: assert(early->dominates(LCA)) failed: early is high enough
  • e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

Your commit was automatically rebased without conflicts.

Pushed as commit cd25bf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr integrated
3 participants