Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8259796: timed CompletableFuture.get may swallow InterruptedException #126

Closed
wants to merge 1 commit into from

Conversation

Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Jan 17, 2021

/cc core-libs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259796: timed CompletableFuture.get may swallow InterruptedException

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/126/head:pull/126
$ git checkout pull/126

@Martin-Buchholz
Copy link
Member Author

/issue add JDK-8259796

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2021

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.java.net labels Jan 17, 2021
@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@Martin-Buchholz
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@Martin-Buchholz This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

mlbridge bot commented Jan 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 17, 2021

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259796: timed CompletableFuture.get may swallow InterruptedException

Reviewed-by: dl, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2021
@Martin-Buchholz
Copy link
Member Author

we additionally tweaked timedGet with slightly cleaner code.

@Martin-Buchholz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2021
@openjdk
Copy link

openjdk bot commented Jan 19, 2021

@Martin-Buchholz Pushed as commit f7b96d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
3 participants