Skip to content
This repository has been archived by the owner. It is now read-only.

8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed #13

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 11, 2020

See JDK-8258101. Need more time to investigate this, and meanwhile Xcomp runs should be clean.

Additional testing:

  • make run-test TEST=compiler/blackhole JTREG="EXTRA_PROBLEM_LISTS=./ProblemList-Xcomp.txt" -- ignores all tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/13/head:pull/13
$ git checkout pull/13

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 11, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 11, 2020

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler label Dec 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@shipilev
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 11, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 11, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed

Reviewed-by: iignatyev, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b7ac32d: 8257598: Clarify what component values are used in Record::equals
  • a280182: 8258060: Update @jls tags for renamed/renumbered sections
  • bacf22b: 8256641: CDS VM operations do not lock the heap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 11, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 12, 2020

/integrate

@openjdk openjdk bot closed this Dec 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 12, 2020

@shipilev Since your change was applied there have been 5 commits pushed to the master branch:

  • 2001da3: 8257596: Clarify trusted final fields for record classes
  • b1afed7: 8257919: [JVMCI] profiling info didn't change after reprofile
  • b7ac32d: 8257598: Clarify what component values are used in Record::equals
  • a280182: 8258060: Update @jls tags for renamed/renumbered sections
  • bacf22b: 8256641: CDS VM operations do not lock the heap

Your commit was automatically rebased without conflicts.

Pushed as commit 6d79ec8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8258111-problemlist-Xcomp-blackhole branch Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler integrated
3 participants