8257215: JFR: Events dropped when streaming over a chunk rotation

[egahlin]

Hi,

Could I have review of an intermittent product issue. It happens about 1 out of 300 the test is run.

By design, chunk files that have been parsed are deleted. Problem is that the filename could be reused, which causes issues. This happens on the server, where the files are read before they are transfered over the network, and on the client when chunks are read from the local repository.

The logic for creating the chunk file names is now in a separate class (ChunkFilename) so it can be shared by server and client. Another problem was the clock source being used when purging files. It was not always the same as when timestamp was taken from the chunk.

Testing: Ran TestRotate.java 2100 times without failure

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257215: JFR: Events dropped when streaming over a chunk rotation

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/131/head:pull/131
$ git checkout pull/131

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (33825ab)
• 00: Full (20bb01d)

[mgronlun]

Looks good.

[egahlin]

/integrate

[openjdk]

@egahlin This PR has not yet been marked as ready for integration.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257215: JFR: Events dropped when streaming over a chunk rotation

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 0fdf9cd: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled
• bc41bb1: 8260632: Build failures after JDK-8253353
• a117e11: 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop
• 8ffdbce: 8260608: add a regression test for 8260370
• 1926765: 8253353: Crash in C2: guarantee(n != NULL) failed: No Node
• e68eac9: 8259765: ZGC: Handle incorrect processor id reported by the operating system
• e28e111: 8260370: C2: LoopLimit node is not eliminated
• 408772c: 8259025: Record compact constructor using Objects.requireNonNull
• 81e730e: 8259276: C2: Empty expression stack when reexecuting tableswitch/lookupswitch instructions after deoptimization

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

@egahlin Since your change was applied there have been 9 commits pushed to the master branch:

• 0fdf9cd: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled
• bc41bb1: 8260632: Build failures after JDK-8253353
• a117e11: 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop
• 8ffdbce: 8260608: add a regression test for 8260370
• 1926765: 8253353: Crash in C2: guarantee(n != NULL) failed: No Node
• e68eac9: 8259765: ZGC: Handle incorrect processor id reported by the operating system
• e28e111: 8260370: C2: LoopLimit node is not eliminated
• 408772c: 8259025: Record compact constructor using Objects.requireNonNull
• 81e730e: 8259276: C2: Empty expression stack when reexecuting tableswitch/lookupswitch instructions after deoptimization

Your commit was automatically rebased without conflicts.

Pushed as commit 21f8bf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.