8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop #132
Conversation
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
@Wanghuang-Huawei The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/contributor add He Xuejin hexuejin2@huawei.com |
@Wanghuang-Huawei |
c1a9301
to
4a50306
Compare
4a50306
to
ee3797d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good.
Since JDK 16 is in rampdown phase 2 (http://openjdk.java.net/jeps/3) - this fix will need additional approval before it can be pushed. I will help out with that.
Thank you for your review and help. |
Hi @Wanghuang-Huawei , I'm still not clear how to reproduce the bug. Is it possible to add a jtreg test for this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need regression test since change is in common code.
given JDK16 is RDP2 and your patch changes the shared code, you are to integrate an automated jtreg test together with the fix. I've taken Thanks, |
/cc hotspot-compiler |
@iignatev |
Ah, I missed the attachment in the JBS. |
Thank you very much. I will push a new commit which contains jtreg test. |
@Wanghuang-Huawei Have you been able to reproduce this on any other platform that linux-aarch64? I'm having trouble reproducing this on x64. |
I tried the reproducer on the JBS just now and couldn't reproduce it on x64 either. |
I think x64 has disabled OptimizeFill by default. I can reproduce this with -XX:+OptimizeFill. |
Please add -XX:+OptimizeFill to the regression test |
Yes, OptimizeFill is off after 8247307 changes in JDK 16. Add it to @run command (it is C2 flag so you need
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Wait an other day for other people to look.
@Wanghuang-Huawei This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@neliasso, @vnkozlov, @iignatev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
@Wanghuang-Huawei |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I will sponsor this change when 24 hours have passed since the last update. |
/sponsor |
@neliasso @Wanghuang-Huawei Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a117e11. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The reason is :
If the
store
is aStoreVectorNode
,theBasicType
isT_VOID
. It seems that we don't need to intrinsify aStoreVectorNode
filling here.I add a new case here to avoid mistake:
Progress
Issue
Reviewers
Contributors
<hexuejin2@huawei.com>
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/132/head:pull/132
$ git checkout pull/132