Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8259025: Record compact constructor using Objects.requireNonNull #133

Conversation

vicente-romero-oracle
Copy link

@vicente-romero-oracle vicente-romero-oracle commented Jan 26, 2021

Hi,

This PR is basically a backport to 16 of the code already reviewed at PR-1917.

TIA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259025: Record compact constructor using Objects.requireNonNull ⚠️ Issue is not open.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/133/head:pull/133
$ git checkout pull/133

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2021

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@vicente-romero-oracle The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.java.net label Jan 26, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2021

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259025: Record compact constructor using Objects.requireNonNull

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@vicente-romero-oracle
Copy link
Author

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2021
@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@vicente-romero-oracle Pushed as commit 408772c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler compiler-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants