Skip to content
This repository has been archived by the owner. It is now read-only.

8260608: add a regression test for 8260370 #137

Closed
wants to merge 2 commits into from

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Jan 28, 2021

Hi all,

could you please review this small and trivial patch that adds a regression test for 8260370 ?

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/137/head:pull/137
$ git checkout pull/137

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 28, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 28, 2021

Webrevs

static int counter = 0;
long b[] = new long[a];

void c(String[] d) {

Please, don't use single latter for constants and method names. It is better to not use them for anything - all names should be meaningful.

Also you need to change RFE to Bug. the process only allows test bugs:
http://openjdk.java.net/jeps/3#rdp-2
RDP2: P1–P5 doc/test bugs

Copy link
Member Author

@iignatev iignatev Jan 28, 2021

Vladimir, there is nothing meaningful about these constants, methods, variables — the whole test is randomly generated.

Got it. But even then, you can at least rename 'c()' to 'test()' and 'a' to 'N'. And add comment that it is randomly generated to avoid complains later.

Copy link

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260608: add a regression test for 8260370

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Jan 29, 2021

thanks, Vladimir.

/integrate

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@iignatev Pushed as commit 8ffdbce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@iignatev iignatev deleted the 8260608 branch Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants