-
Notifications
You must be signed in to change notification settings - Fork 78
8260608: add a regression test for 8260370 #137
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
Webrevs
|
static int counter = 0; | ||
long b[] = new long[a]; | ||
|
||
void c(String[] d) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't use single latter for constants and method names. It is better to not use them for anything - all names should be meaningful.
Also you need to change RFE to Bug. the process only allows test bugs:
http://openjdk.java.net/jeps/3#rdp-2
RDP2: P1–P5 doc/test bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vladimir, there is nothing meaningful about these constants, methods, variables — the whole test is randomly generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. But even then, you can at least rename 'c()' to 'test()' and 'a' to 'N'. And add comment that it is randomly generated to avoid complains later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@iignatev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
thanks, Vladimir. /integrate |
Hi all,
could you please review this small and trivial patch that adds a regression test for 8260370 ?
Thanks,
-- Igor
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/137/head:pull/137
$ git checkout pull/137