Skip to content
This repository has been archived by the owner. It is now read-only.

8260704: ParallelGC: oldgen expansion needs release-store for _end #141

Closed
wants to merge 2 commits into from
Closed

8260704: ParallelGC: oldgen expansion needs release-store for _end #141

wants to merge 2 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Feb 1, 2021

Please review this change that ensures MutableSpace::_end is updated after
everything else that is relevant when expanding, by using a release_store to
perform the update. With this change the storestore that was added by
JDK-8257999 is no longer needed.

Testing:
mach5 tier1-3, tier5

/summary Move JDK-8257999 barrier to correct location.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260704: ParallelGC: oldgen expansion needs release-store for _end

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/141/head:pull/141
$ git checkout pull/141

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@kimbarrett Setting summary to Move JDK-8257999 barrier to correct location.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Feb 1, 2021
@kimbarrett kimbarrett marked this pull request as ready for review Feb 1, 2021
@openjdk openjdk bot added the rfr label Feb 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Copy link

@tschatzl tschatzl left a comment

Lgtm

@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260704: ParallelGC: oldgen expansion needs release-store for _end

Move JDK-8257999 barrier to correct location.

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 2, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Feb 2, 2021

Thanks @tschatzl and @kstefanj for reviews.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Feb 2, 2021

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@kimbarrett Pushed as commit afd5eef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-gc integrated
3 participants