Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8258378: Final nroff manpage update for JDK 16 #142

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Feb 1, 2021

Before RC phase we need to ensure we have the final set of manpage updates published in OpenJDK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/142/head:pull/142
$ git checkout pull/142

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@magicus The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.java.net serviceability serviceability-dev@openjdk.java.net build build-dev@openjdk.java.net core-libs core-libs-dev@openjdk.java.net compiler compiler-dev@openjdk.java.net kulla kulla-dev@openjdk.java.net hotspot-jfr hotspot-jfr-dev@openjdk.java.net labels Feb 1, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2021

Webrevs

@magicus
Copy link
Member Author

magicus commented Feb 1, 2021

/label remove serviceability compiler kulla hotspot-jfr

@openjdk openjdk bot removed serviceability serviceability-dev@openjdk.java.net compiler compiler-dev@openjdk.java.net kulla kulla-dev@openjdk.java.net hotspot-jfr hotspot-jfr-dev@openjdk.java.net labels Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@magicus
The serviceability label was successfully removed.

The compiler label was successfully removed.

The kulla label was successfully removed.

The hotspot-jfr label was successfully removed.

@magicus
Copy link
Member Author

magicus commented Feb 1, 2021

These updates have been made automatically from the markdown source files (which unfortunately is still closed-only).

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258378: Final nroff manpage update for JDK 16

Reviewed-by: erikj, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Magnus! I had overlooked the fact we would need to re-run this in 2021 regardless of whether there were any content changes to propagate.

Cheers,
David

@magicus
Copy link
Member Author

magicus commented Feb 2, 2021

@dholmes-ora I did not think of that myself either. But the make target did the Right Thing. :-)

@magicus
Copy link
Member Author

magicus commented Feb 2, 2021

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@magicus Pushed as commit ed1a775.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the update-man-pages branch February 8, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build build-dev@openjdk.java.net core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated javadoc javadoc-dev@openjdk.java.net
Development

Successfully merging this pull request may close these issues.

3 participants