Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35) #146

Closed
wants to merge 1 commit into from

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Feb 2, 2021

We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to remove the EA from version string for this build (b35) and going forward.

Pushing this for @pashh


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/146/head:pull/146
$ git checkout pull/146

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2021

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

⚠️ @JesperIRL a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 081fa3e7154db433b10b940ff223fd3d50099521
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@JesperIRL The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.java.net label Feb 2, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

Reviewed-by: iignatyev, mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • afd5eef: 8260704: ParallelGC: oldgen expansion needs release-store for _end

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2021
@JesperIRL
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@JesperIRL Since your change was applied there has been 1 commit pushed to the master branch:

  • afd5eef: 8260704: ParallelGC: oldgen expansion needs release-store for _end

Your commit was automatically rebased without conflicts.

Pushed as commit 1a7040e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build build-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants