Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8258140: Update @jls tags in java.base for renamed/renumbered sections #15

Closed
wants to merge 1 commit into from
Closed

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 12, 2020

Given upcoming changes in the JLS terminology around the term "type", various sections were renamed:

https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html

The @jls tags in the java.base module which refer to the renamed sections should be updated.
Analogous changes in the java.compiler module made under JDK-8258060.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258140: Update @jls tags in java.base for renamed/renumbered sections

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/15/head:pull/15
$ git checkout pull/15

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2020

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2020
@openjdk
Copy link

openjdk bot commented Dec 12, 2020

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Dec 12, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258140: Update @jls tags in java.base for renamed/renumbered sections

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used
  • 09e8675: 8255381: com/sun/jdi/EATests.java should not suspend graal threads
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • 6d79ec8: 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
  • 2001da3: 8257596: Clarify trusted final fields for record classes
  • b1afed7: 8257919: [JVMCI] profiling info didn't change after reprofile

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2020
@jddarcy
Copy link
Member Author

jddarcy commented Dec 15, 2020

/integrate

@openjdk openjdk bot closed this Dec 15, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2020
@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@jddarcy Since your change was applied there have been 10 commits pushed to the master branch:

  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used
  • 09e8675: 8255381: com/sun/jdi/EATests.java should not suspend graal threads
  • afc4441: 8258094: AIX build fails after 8257602
  • 164c8a6: 8258092: Link to early access platform documentation in TestHtmlTableTags.java
  • 43dc3f7: 8254350: CompletableFuture.get may swallow InterruptedException
  • 6d79ec8: 8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
  • 2001da3: 8257596: Clarify trusted final fields for record classes
  • b1afed7: 8257919: [JVMCI] profiling info didn't change after reprofile

Your commit was automatically rebased without conflicts.

Pushed as commit e911351.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
2 participants