Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8254350: CompletableFuture.get may swallow InterruptedException #17

Closed
wants to merge 1 commit into from

Conversation

Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Dec 13, 2020


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254350: CompletableFuture.get may swallow InterruptedException

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/17/head:pull/17
$ git checkout pull/17

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2020

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2020

@Martin-Buchholz The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.java.net rfr Pull request is ready for review labels Dec 13, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2020

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously reviewed for openjdk/jdk, looks good.

@openjdk
Copy link

openjdk bot commented Dec 13, 2020

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254350: CompletableFuture.get may swallow InterruptedException

Reviewed-by: alanb, dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2020
@Martin-Buchholz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Dec 13, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2020
@openjdk
Copy link

openjdk bot commented Dec 13, 2020

@Martin-Buchholz Pushed as commit 43dc3f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kezhuw
Copy link

kezhuw commented Jan 14, 2021

@Martin-Buchholz @DougLea @AlanBateman Sorry for rough in. After change future.get() to future.get(1, TimeUnit.DAYS), SwallowedInterruptedException failed.

@Martin-Buchholz
Copy link
Member Author

Thanks, Kezhu. I filed:
https://bugs.openjdk.java.net/browse/JDK-8259796

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants