Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8257910: [JVMCI] Set exception_seen accordingly in the runtime. #2

Closed

Conversation

mur47x111
Copy link

@mur47x111 mur47x111 commented Dec 10, 2020

Update exception_seen flag in the MDO when no exception handler is found for caller during deoptimization, or when exception is thrown in the runtime.

Plus, -Xlog:exceptions=info code and AbortVMOnException are adjusted in C1 runtime and jvmci runtime to be consistent with C2, i.e., before JvmtiExport::can_post_on_exceptions deoptimization and fast continuation when compiled handler is found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257910: [JVMCI] Set exception_seen accordingly in the runtime.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/2/head:pull/2
$ git checkout pull/2

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2020

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mur47x111 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 10, 2020

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257910: [JVMCI] Set exception_seen accordingly in the runtime.

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2020
@mur47x111
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@mur47x111
Your change (at version 48186e9) is now ready to be sponsored by a Committer.

@mur47x111
Copy link
Author

@vnkozlov I am not a committer, would you please sponsor this change?

@vnkozlov
Copy link

I will sponsor it after testing.

@vnkozlov
Copy link

Passed hs-tier1-3 JDK 16 testing.
/sponsor

@openjdk openjdk bot closed this Dec 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2020
@openjdk
Copy link

openjdk bot commented Dec 10, 2020

@vnkozlov @mur47x111 Since your change was applied there have been 2 commits pushed to the master branch:

  • e90d0d1: 8258065: ProblemList JfrGTestAdaptiveSampling
  • fa77008: 8258015: [JVMCI] JVMCI_lock shouldn't be held while initializing box classes

Your commit was automatically rebased without conflicts.

Pushed as commit 58dca92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot integrated Pull request has been integrated
2 participants