Skip to content
This repository has been archived by the owner. It is now read-only.

8258419: RSA cipher buffer cleanup #26

Closed
wants to merge 1 commit into from
Closed

8258419: RSA cipher buffer cleanup #26

wants to merge 1 commit into from

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 15, 2020

Some array allocation is not necessary, and the content can be cleaned.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/26/head:pull/26
$ git checkout pull/26

8258419: RSA cipher buffer cleanup
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 15, 2020

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Dec 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2020

Webrevs

Loading

@valeriepeng
Copy link

@valeriepeng valeriepeng commented Dec 15, 2020

Need a noreg-xxx label since there is no regression test.

Loading

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 15, 2020

Need a noreg-xxx label since there is no regression test.

noreg-cleanup Added. Thanks.

Loading

Copy link

@valeriepeng valeriepeng left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258419: RSA cipher buffer cleanup

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e911351: 8258140: Update @jls tags in java.base for renamed/renumbered sections
  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used
  • 09e8675: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 15, 2020
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 15, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@wangweij Since your change was applied there have been 7 commits pushed to the master branch:

  • 1f556d2: 8258380: [JVMCI] don't clear InstalledCode reference when unloading JVMCI nmethods
  • e7aa5fe: 8258427: Problem List some tests related to FileDialog for MacOS
  • e911351: 8258140: Update @jls tags in java.base for renamed/renumbered sections
  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used
  • 09e8675: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

Your commit was automatically rebased without conflicts.

Pushed as commit b97fe6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@wangweij wangweij deleted the 8258419 branch Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants