Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

8257637: Update usage of "type" terminology in java.lang.annotation #27

Closed
wants to merge 5 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Dec 15, 2020

This change is in line with upcoming changes in the JLS terminology ('type' versus 'class and interface').

For background see: https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html

For easier reviewing, paragraphs will only be reflowed before the PR is integrated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257637: Update usage of "type" terminology in java.lang.annotation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/27/head:pull/27
$ git checkout pull/27

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2020

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2020

⚠️ @FrauBoes This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2020
@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@FrauBoes The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Dec 15, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2020

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257637: Update usage of "type" terminology in java.lang.annotation

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • b5a3a5b: 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
  • b97fe6c: 8258419: RSA cipher buffer cleanup
  • 1f556d2: 8258380: [JVMCI] don't clear InstalledCode reference when unloading JVMCI nmethods
  • e7aa5fe: 8258427: Problem List some tests related to FileDialog for MacOS
  • e911351: 8258140: Update @jls tags in java.base for renamed/renumbered sections
  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2020
@FrauBoes
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2020
@openjdk
Copy link

openjdk bot commented Dec 16, 2020

@FrauBoes Since your change was applied there have been 8 commits pushed to the master branch:

  • b5a3a5b: 8258236: Segfault in ClassListParser::resolve_indy dumping static AppCDS archive
  • b97fe6c: 8258419: RSA cipher buffer cleanup
  • 1f556d2: 8258380: [JVMCI] don't clear InstalledCode reference when unloading JVMCI nmethods
  • e7aa5fe: 8258427: Problem List some tests related to FileDialog for MacOS
  • e911351: 8258140: Update @jls tags in java.base for renamed/renumbered sections
  • ce36aea: 8257822: C2 crashes with SIGFPE due to a division that floats above its zero check
  • fa1cbb4: 8258404: Restore stacktrace reuse after 8258094
  • 7ff9c85: 8258242: Type profile pollution occurs when memory segments of different kinds are used

Your commit was automatically rebased without conflicts.

Pushed as commit 72dfba8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants