-
Notifications
You must be signed in to change notification settings - Fork 77
8256693: getAnnotatedReceiverType parameterizes types too eagerly #33
Conversation
Check type argument arrays from ParameterizedType and AnnotatedParameterizedType has same length testing generation of the empty case.
👋 Welcome back jfranck! A progress list of the required criteria for merging this PR into |
Webrevs
|
test/jdk/java/lang/annotation/typeAnnotations/GetAnnotatedReceiverType.java
Outdated
Show resolved
Hide resolved
@jbf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@jbf Since your change was applied there have been 20 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1cc98bd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The fix for JDK-8256693 too often produces a ParameterizedType as the result of getAnnotatedReceiverType().getType() . A ParameterizedType is necessary only when this type or any of its transitive owner types has type parameters, but should be avoided if this isn't the case.
This implementation recursively creates a chain of ParameterizedTypes starting from the outermost type that has type parameters.
See here for the now closed JDK 17 pr: openjdk/jdk#1414
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/33/head:pull/33
$ git checkout pull/33