8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation

[lgxbslgx]

Hi all,

This patch adds names.MODULE to com.sun.tools.javac.comp.Check.dfltTargetMeta to fix this issue. And it also adds some corresponding tests.

The previous discussion is in openjdk/jdk#622.

Best Regards.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254023: A module declaration is not allowed to be a target of an annotation that lacks an @target meta-annotation

Reviewers

• Joel Borggrén-Franck (@jbf - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/34/head:pull/34
$ git checkout pull/34

[bridgekeeper]

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f283b3b)

[jbf]

Can you update your fork to do pre-submit tests and trigger a manual run?

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254023: A module declaration is not allowed to be a target of an annotation that lacks an @Target meta-annotation

Reviewed-by: jfranck, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jbf, @vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

Can you update your fork to do pre-submit tests and trigger a manual run?

Get!

/integrate

[openjdk]

@lgxbslgx
Your change (at version f283b3b) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

looks good

[jbf]

/sponsor

[openjdk]

@jbf @lgxbslgx Since your change was applied there have been 3 commits pushed to the master branch:

• ce0ab2d: 8258338: Support deprecated records
• 6b4b676: 8241353: NPE in ToolProvider.getSystemJavaCompiler
• 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed

Your commit was automatically rebased without conflicts.

Pushed as commit 41f312e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[wmdietl]

@lgxbslgx I'm confused by the "is not allowed". Isn't this testing that this is allowed without an error?
I realize that that is in the tile of JDK-8254023, but the resolution is to allow such annotations, right?