Skip to content
This repository has been archived by the owner. It is now read-only.

8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions #37

Closed
wants to merge 1 commit into from

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Dec 16, 2020

Just adding the missing -XX:+UnlockDiagnosticVMOptions flag to the test.

Thanks,
Christian


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/37/head:pull/37
$ git checkout pull/37

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2020

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions

Reviewed-by: thartmann, kvn, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 16, 2020

Webrevs

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 16, 2020

This failure is happening in the JDK16 CI. Please integrate this fix into JDK16
and it will be sync'ed to the jdk/jdk repo by Jesper.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 17, 2020

Thanks @TobiHartmann, @vnkozlov and @dcubed-ojdk for your reviews!

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 17, 2020

/integrate

@openjdk openjdk bot closed this Dec 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@chhagedorn Since your change was applied there have been 4 commits pushed to the master branch:

  • 41f312e: 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @target meta-annotation
  • ce0ab2d: 8258338: Support deprecated records
  • 6b4b676: 8241353: NPE in ToolProvider.getSystemJavaCompiler
  • 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed

Your commit was automatically rebased without conflicts.

Pushed as commit 04a1e5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants