8255880: UI of Swing components is not redrawn after their internal state changed

[alitvinv]

Hello,

This is a review request for straight back port of the fix for the bug JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The fix was tested and the regression test was executed on MS Windows OS, Linux OS, macOS.

Thank you,
Anton

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255880: UI of Swing components is not redrawn after their internal state changed

Reviewers

• Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/38/head:pull/38
$ git checkout pull/38

[bridgekeeper]

👋 Welcome back alitvinov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@alitvinv This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255880: UI of Swing components is not redrawn after their internal state changed

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alitvinv The following labels will be automatically applied to this pull request:

• awt
• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (69897b7)

[prrace]

Fine but in that casw why didn't you withdraw the 17 PR and just push to 16 which will get forward synced ?

[alitvinv]

/integrate

[openjdk]

@alitvinv Pushed as commit 87644a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[alitvinv]

Hello Phil. For me the main goal was to fix this bug in the latest JDK feature release, that is why I initiated integration to "openjdk/jdk" as soon as the fix was approved there. Integration of this fix to "openjdk/jdk" repository was my first integration to OpenJDK project in Git, at that moment I did not anticipate that obligatory synchronization from "openjdk/jdk16" to "openjdk/jdk" yet. Today based on the fact that this bug is P3 and not an enhancement and that following "fix-request" process in JBS is not prescribed for this type of bug in RDP 1 phase, and that this bug on Monday still was targeted to JDK 16, I came to a conclusion that there is legal right to go through this back port procedure to try to deliver the fix to JDK 16. I thought that there would not be a trouble during this synchronization, because in Mercurial such cases during merge were handled automatically silently. Hopefully Git will manage to handle it automatically. I guarantee that this is the first and last time from my side, next times, if there are, I will not be initiating back ports to stabilization repositories in pre-RDP 2 phases, if the fix is integrated to always open repository.

…

On 16/12/2020 19:47, prrace wrote: ***@***.**** approved this pull request. Fine but in that casw why didn't you withdraw the 17 PR and just push to 16 which will get forward synced ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jdk16/pull/38*pullrequestreview-554028620__;Iw!!GqivPVa7Brio!Klj4EK4RrD6Ivj-inV3MaaZOe1byFdk_Gc3CiAQr3B7qKv70SsuZx4n6HCvGZl9q6Xg$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQY7S7HOZTSK3ZGZNM3A5R3SVEFEBANCNFSM4U6PRW5Q__;!!GqivPVa7Brio!Klj4EK4RrD6Ivj-inV3MaaZOe1byFdk_Gc3CiAQr3B7qKv70SsuZx4n6HCvGh1BcT_U$>.