Skip to content
This repository has been archived by the owner. It is now read-only.

8258373: Update the text handling in the JPasswordField #39

Closed
wants to merge 1 commit into from
Closed

8258373: Update the text handling in the JPasswordField #39

wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 16, 2020

  • The JTextComponent.setText() is overidden in the JPasswordField to make the "text" property non-"bound" in the JPasswordField, same as in the JTextComponent
  • The new implementation of setText() clean an internal data storage
  • Also some internal caches are cleaned as well

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258373: Update the text handling in the JPasswordField

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/39/head:pull/39
$ git checkout pull/39

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 16, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@mrserb The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Dec 16, 2020
@mrserb mrserb marked this pull request as ready for review Dec 16, 2020
@openjdk openjdk bot added the rfr label Dec 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 16, 2020

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258373: Update the text handling in the JPasswordField

Reviewed-by: kizune, prr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • cbc3fee: 8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812
  • 7320e05: 8258647: TestCharVect2 is very slow
  • 9fdfc6d: 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • ... and 5 more: https://git.openjdk.java.net/jdk16/compare/72dfba8053ed5c159b832349ce5290b053ed37ad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@victordyakov Unknown command approve - for a list of valid commands use /help.

@victordyakov
Copy link

@victordyakov victordyakov commented Dec 17, 2020

Looks good.

@Override
@BeanProperty(bound = false, description = "the text of this component")
public void setText(String t) {
// overwrite the old data first
Copy link
Contributor

@prsadhuk prsadhuk Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we dont have javadoc for a public method, wouldn't build like make-docs fail?

Copy link
Member Author

@mrserb mrserb Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"make docs" works fine.

prrace
prrace approved these changes Dec 17, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 18, 2020

/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@mrserb Since your change was applied there have been 15 commits pushed to the master branch:

  • cbc3fee: 8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812
  • 7320e05: 8258647: TestCharVect2 is very slow
  • 9fdfc6d: 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • ... and 5 more: https://git.openjdk.java.net/jdk16/compare/72dfba8053ed5c159b832349ce5290b053ed37ad...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7afb01d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8258373 branch Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated swing
5 participants