Skip to content
This repository has been archived by the owner. It is now read-only.

8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812 #40

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Dec 17, 2020

Back out code changes from JDK-8235812 to restore correct matching behavior. Adjust test to comment out cases that tested for incorrect behavior.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/40/head:pull/40
$ git checkout pull/40

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 17, 2020

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Dec 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 17, 2020

Webrevs

naotoj
naotoj approved these changes Dec 17, 2020
Copy link
Member

@naotoj naotoj left a comment

Backout and test changes according to it look good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258259: Unicode linebreak matching behavior is incorrect; backout JDK-8235812

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • 04a1e5b: 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
  • 41f312e: 8254023: A module declaration is not allowed to be a target of an annotation that lacks an @target meta-annotation
  • ce0ab2d: 8258338: Support deprecated records
  • 6b4b676: 8241353: NPE in ToolProvider.getSystemJavaCompiler
  • 87644a2: 8255880: UI of Swing components is not redrawn after their internal state changed
  • 72dfba8: 8257637: Update usage of "type" terminology in java.lang.annotation
  • ... and 9 more: https://git.openjdk.java.net/jdk16/compare/afc44414d551d9fc342a733651777227f2f95eac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 17, 2020
@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Dec 18, 2020

/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 18, 2020

@stuart-marks Since your change was applied there have been 24 commits pushed to the master branch:

  • 7320e05: 8258647: TestCharVect2 is very slow
  • 9fdfc6d: 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings
  • 61390d8: 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region is not in covered_region
  • 952dc70: 8257636: Update usage of "type" terminology in java.lang.Class and java.lang.reflect
  • 04a1e5b: 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing UnlockDiagnosticVMOptions
  • ... and 14 more: https://git.openjdk.java.net/jdk16/compare/afc44414d551d9fc342a733651777227f2f95eac...master

Your commit was automatically rebased without conflicts.

Pushed as commit cbc3fee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants