8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter

[neliasso]

Exclude test-method from compiler/c2/cr6340864-tests.

In debug builds - the C1 method IR::verify is very costly in big methods with many blocks. The compile times explode. A sub minute test takes 35 minutes on slower machines - and these tests are run multiple times.

Some of these tests are saved by the HugeMethodLimit, but some (TestIntVect and TestLongVect) doesn't.

Please review,
Nils

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer) ⚠️ Review applies to 255b456
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/44/head:pull/44
$ git checkout pull/44

[bridgekeeper]

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@neliasso The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (487e4c2)
• 00: Full (255b456)

[iwanowww]

Looks good.

(Wasn't aware about class::method() syntax support in -XX:CompileCommand.)

Does it make sense to reconsider the timeout value (from 400 to a lower value)?

[openjdk]

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter

Reviewed-by: vlivanov, thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
• 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[neliasso]

Thank you Vladimir and Tobias!

Does it make sense to reconsider the timeout value (from 400 to a lower value)?

Yes it a good suggestion. I will remove the timout so that the default of 120 (before scaling) is used.

[neliasso]

/integrate

[openjdk]

@neliasso Since your change was applied there have been 2 commits pushed to the master branch:

• 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
• 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings

Your commit was automatically rebased without conflicts.

Pushed as commit cb5a6b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.