Skip to content
This repository has been archived by the owner. It is now read-only.

8258647: TestCharVect2 is very slow #46

Closed
wants to merge 1 commit into from

Conversation

@neliasso
Copy link
Contributor

@neliasso neliasso commented Dec 17, 2020

This is fixes compiler/codegen/TestCharVect2.java that suffers from the same problems as the tests fixed in JDK-8258225.

With the fix the test is fast enough to run with c1 only - so I removed the @requires attribute.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/46/head:pull/46
$ git checkout pull/46

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 17, 2020

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@neliasso The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 17, 2020

Webrevs

Loading

Copy link

@iwanowww iwanowww left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258647: TestCharVect2 is very slow

Reviewed-by: vlivanov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9fdfc6d: 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 17, 2020
@neliasso
Copy link
Contributor Author

@neliasso neliasso commented Dec 17, 2020

I can add that all the other tests that seem to be auto generated in the same format, they all run with -XX:-TieredCompilation and are not subject to this problem.

Loading

@neliasso
Copy link
Contributor Author

@neliasso neliasso commented Dec 17, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 17, 2020

@neliasso Since your change was applied there have been 6 commits pushed to the master branch:

  • 9fdfc6d: 8225072: Add LuxTrust certificate that is expiring in March 2021 to list of allowed but expired certs
  • 30ca0a5: 8247994: Localize javadoc search
  • 47c180d: 8258515: javac should issue an error if an annotation is nested in a local class or interface
  • cb5a6b1: 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
  • 61cbf0f: 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with RuntimePackageTest.testUsrInstallDir2
  • 7aac4dc: 8257621: JFR StringPool misses cached items across consecutive recordings

Your commit was automatically rebased without conflicts.

Pushed as commit 7320e05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants