-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@neliasso This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
I can add that all the other tests that seem to be auto generated in the same format, they all run with -XX:-TieredCompilation and are not subject to this problem. |
/integrate |
@neliasso Since your change was applied there have been 6 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7320e05. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is fixes compiler/codegen/TestCharVect2.java that suffers from the same problems as the tests fixed in JDK-8258225.
With the fix the test is fast enough to run with c1 only - so I removed the @requires attribute.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/46/head:pull/46
$ git checkout pull/46