8257598: Clarify what component values are used in Record::equals

[vicente-romero-oracle]

Please review this patch which modifies the spec for method java.lang.Record::equals. It states that the implementation of this method should use the record fields for the comparison instead of the accessors.

TIA,
Vicente

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257598: Clarify what component values are used in Record::equals

Reviewers

• Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to 73e8ad5
• Chris Hegarty (@ChrisHegarty - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/5/head:pull/5
$ git checkout pull/5

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[vicente-romero-oracle]

/label remove compiler

[openjdk]

@vicente-romero-oracle
The compiler label was successfully removed.

[mlbridge]

Webrevs

• 01: Full - Incremental (566b78d)
• 00: Full (73e8ad5)

[jddarcy]

Looks fine.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257598: Clarify what component values are used in Record::equals

Reviewed-by: darcy, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ChrisHegarty]

The change and test look good to me. Thanks Vicente.

I have just one minor comment on the location of the test. I know there is not always a clear and clean separation across component areas, but another possible location, for your consideration, is test/jdk/java/lang/reflect/record - which contains other runtime tests for records.

[vicente-romero-oracle]

The change and test look good to me. Thanks Vicente.

I have just one minor comment on the location of the test. I know there is not always a clear and clean separation across component areas, but another possible location, for your consideration, is test/jdk/java/lang/reflect/record - which contains other runtime tests for records.

thanks for your comments, I have moved the test to another location

[vicente-romero-oracle]

/integrate

[openjdk]

@vicente-romero-oracle Since your change was applied there have been 2 commits pushed to the master branch:

• a280182: 8258060: Update @jls tags for renamed/renumbered sections
• bacf22b: 8256641: CDS VM operations do not lock the heap

Your commit was automatically rebased without conflicts.

Pushed as commit b7ac32d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.