-
Notifications
You must be signed in to change notification settings - Fork 78
8258687: Build broken on Windows after fix for JDK-8258134 #51
Conversation
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
/issue add JDK-8258687 |
@DamonFool This issue is referenced in the PR title - it will now be updated. |
@DamonFool |
@DamonFool The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @TobiHartmann . |
@DamonFool Pushed as commit 59ae054. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/51/head:pull/51
$ git checkout pull/51