Skip to content
This repository has been archived by the owner. It is now read-only.

8258687: Build broken on Windows after fix for JDK-8258134 #51

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 18, 2020


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258687: Build broken on Windows after fix for JDK-8258134

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/51/head:pull/51
$ git checkout pull/51

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool
Copy link
Member Author

DamonFool commented Dec 18, 2020

/issue add JDK-8258687
/test
/label add hotspot-compiler
/cc hotspot-compiler

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.java.net label Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

mlbridge bot commented Dec 18, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258687: Build broken on Windows after fix for JDK-8258134

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2020
@DamonFool
Copy link
Member Author

DamonFool commented Dec 18, 2020

Thanks @TobiHartmann .
/integrate

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@DamonFool Pushed as commit 59ae054.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8258687 branch Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.java.net integrated Pull request has been integrated
2 participants