8223607: --override-methods=summary ignores some signature changes

[hns]

Jon,

I created a new pull request for this on the jdk16 repository because the original one was created on the mainline jdk repo. The first commit in this PR is identical to the one you already reviewed in the old PR. The second commit adds checks and tests for changes from non-final to final and changes in abstractness of overriding methods. Thus the full list of conditions under which a simple overriding method is included in the details section of the overriding class is now:

- method access changes from protected to public
- method is overridden as final
- method overridden with different abstractness
- any change in thrown exceptions
- change in documented annotations anywhere in the method signature

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8223607: --override-methods=summary ignores some signature changes

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/52/head:pull/52
$ git checkout pull/52

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c7e4691)
• 00: Full (f3b88db)

[jonathan-gibbons]

Nice.

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223607: --override-methods=summary ignores some signature changes

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
• 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
• 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

@hns Since your change was applied there have been 4 commits pushed to the master branch:

• 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
• 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
• 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
• 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines

Your commit was automatically rebased without conflicts.

Pushed as commit 45bd3b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.