Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

JDK-8258443: doclint should be service-loaded with system class loader #54

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 19, 2020

Trivial fix to use the system class loader when loading doclint for javac


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258443: doclint should be service-loaded with system class loader

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/54/head:pull/54
$ git checkout pull/54

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2020
@openjdk
Copy link

openjdk bot commented Dec 19, 2020

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.java.net compiler compiler-dev@openjdk.java.net labels Dec 19, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2020

Webrevs

Copy link

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should allow JDK-8253996 to be closed too.

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258443: doclint should be service-loaded with system class loader

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Dec 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@jonathan-gibbons Since your change was applied there have been 2 commits pushed to the master branch:

  • 4e8338e: 8255763: C2: OSR miscompilation caused by invalid memory instruction placement
  • 2525f39: 8258714: Shenandoah: Process references before evacuation during degen

Your commit was automatically rebased without conflicts.

Pushed as commit 8da7c58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented Dec 21, 2020

@AlanBateman JDK-8253996 is slightly different; my intent is that javac/doclint should give a more friendly message when doclint is really not available, such as in a minimal jlink-ed image.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler compiler-dev@openjdk.java.net integrated Pull request has been integrated javadoc javadoc-dev@openjdk.java.net
2 participants