Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java #57

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 21, 2020

ProblemList three jstatd tests on Win* to reduce the noise in the JDK16 CI.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/57/head:pull/57
$ git checkout pull/57

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2020

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label serviceability-dev hotspot-runtime

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.java.net hotspot-runtime hotspot-runtime-dev@openjdk.java.net labels Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@dcubed-ojdk
The serviceability label was successfully added.

The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

Links to the JDK16 CI failures for each of the three tests are in the bug report.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 21, 2020 22:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java

Reviewed-by: amenkov, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
@dcubed-ojdk
Copy link
Member Author

@alexmenkov and @plummercj - Thanks for the fast reviews.

/integrate

@openjdk openjdk bot closed this Dec 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 772addf: 8258790: C2: Crash on empty macro node list

Your commit was automatically rebased without conflicts.

Pushed as commit 88dd6a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8258802 branch December 22, 2020 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.java.net integrated Pull request has been integrated serviceability serviceability-dev@openjdk.java.net
3 participants