Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing #60

Closed

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 23, 2020

This PR improves the diagnostic when javac is run in an image that does not provide a service provider for DocLint.

Instead of reporting messages about unsupported options, the following warning will be generated:

Warning: No service provider for doclint is available

In addition, as a minor cleanup, in the jdk.javadoc module, javadoc b bypasses the service loader to access doclint directly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/60/head:pull/60
$ git checkout pull/60

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2020

Webrevs

hns
hns approved these changes Jan 11, 2021
Copy link
Member

@hns hns left a comment

Looks good!


List<String> actualOutput;
List<String> expectedOutput = List.of(
"- compiler.warn.doclint.not.available",
Copy link
Member

@hns hns Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the warning key printed instead of the warning message? Limited image breaks property lookup?

Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is common practice in jdk.compiler tests to use -XDrawDiagnostics which disables the use of resource files. The reason is to isolate the tests from the locale in which they may be executed, and from minor changes in the resources in the resource files, like spelling and grammar fixes, etc.

"1 warning"
);

//check proper diagnostics when zip/jar FS not present:
Copy link
Member

@hns hns Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "doclint" or "javadoc" instead of "zip/jar FS"

Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to double check, but yes; thanks: good catch

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 11, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 11, 2021

/integrate

@openjdk openjdk bot closed this Jan 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@jonathan-gibbons Pushed as commit 2cb271e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants