JDK-8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing #60
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
added
javadoc
Webrevs
|
|
|
||
| List<String> actualOutput; | ||
| List<String> expectedOutput = List.of( | ||
| "- compiler.warn.doclint.not.available", |
There was a problem hiding this comment.
Why is the warning key printed instead of the warning message? Limited image breaks property lookup?
There was a problem hiding this comment.
It is common practice in jdk.compiler tests to use -XDrawDiagnostics which disables the use of resource files. The reason is to isolate the tests from the locale in which they may be executed, and from minor changes in the resources in the resource files, like spelling and grammar fixes, etc.
| "1 warning" | ||
| ); | ||
|
|
||
| //check proper diagnostics when zip/jar FS not present: |
There was a problem hiding this comment.
Should be "doclint" or "javadoc" instead of "zip/jar FS"
There was a problem hiding this comment.
I had to double check, but yes; thanks: good catch
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
openjdk
bot
added
integrated
|
@jonathan-gibbons Pushed as commit 2cb271e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR improves the diagnostic when javac is run in an image that does not provide a service provider for DocLint.
Instead of reporting messages about unsupported options, the following warning will be generated:
In addition, as a minor cleanup, in the
jdk.javadocmodule, javadoc b bypasses the service loader to accessdoclintdirectly.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/60/head:pull/60$ git checkout pull/60