Skip to content
This repository has been archived by the owner. It is now read-only.

8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS #61

Closed
wants to merge 3 commits into from
Closed

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Dec 23, 2020

This is rollback of the fix for https://bugs.openjdk.java.net/browse/JDK-8230869
That functionality was disabled due to the bug in the macOS Catalina, that bug was fixed so we can reenable the ICON_BADGE_NUMBER feature.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/61/head:pull/61
$ git checkout pull/61

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Dec 23, 2020
@mrserb mrserb marked this pull request as ready for review Dec 23, 2020
@openjdk openjdk bot added the rfr label Dec 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

I can confirm that this works on macOS Catalina and Big Sur.

prrace
prrace approved these changes Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS

Reviewed-by: kcr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 24, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 26, 2020

/integrate

@openjdk openjdk bot closed this Dec 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 26, 2020

@mrserb Pushed as commit fb607f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8245922 branch Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants