8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

[lgxbslgx]

Hi all,

The method Types.isCastable uses method Types.areDisjoint to do some check. But Types.isCastable doesn't check the type of the parameter before invoking method Types.areDisjoint. This patch adds the corresponding check and add a test case.

The original patch is in openjdk/jdk#1849.

Thank you for taking the time to review.

Best Regards.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to 4b07c7b

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/63/head:pull/63
$ git checkout pull/63

[bridgekeeper]

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1dec0e3)
• 00: Full (4b07c7b)

[vicente-romero-oracle]

looks good

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• fb607f1: 8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS
• 3f67afd: 8251377: [macos11] JTabbedPane selected tab text is barely legible
• e2aa724: 8258941: Test specify the Classpath exception in the header
• c398a82: 8258916: javac/doclint reports broken HTML on multiline mailto links
• 23b83c5: 8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov
• 8b37c2c: 8257468: runtime/whitebox/TestWBDeflateIdleMonitors.java fails with Monitor should be deflated.: expected true to equal false
• 9cd8e38: 8257521: runtime/logging/MonitorInflationTest.java crashed in MonitorList::unlink_deflated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lgxbslgx]

@vicente-romero-oracle I revised the legal header. Thank you for taking the time to review.

[lgxbslgx]

/integrate

[openjdk]

@lgxbslgx
Your change (at version 1dec0e3) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

@vicente-romero-oracle @lgxbslgx Since your change was applied there have been 7 commits pushed to the master branch:

• fb607f1: 8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS
• 3f67afd: 8251377: [macos11] JTabbedPane selected tab text is barely legible
• e2aa724: 8258941: Test specify the Classpath exception in the header
• c398a82: 8258916: javac/doclint reports broken HTML on multiline mailto links
• 23b83c5: 8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov
• 8b37c2c: 8257468: runtime/whitebox/TestWBDeflateIdleMonitors.java fails with Monitor should be deflated.: expected true to equal false
• 9cd8e38: 8257521: runtime/logging/MonitorInflationTest.java crashed in MonitorList::unlink_deflated

Your commit was automatically rebased without conflicts.

Pushed as commit 881bceb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.