Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8258941: Test specify the Classpath exception in the header #69

Closed
wants to merge 1 commit into from

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 24, 2020

Fix up legal headers.
One header is replaced by /nodynamiccopyright/ because changing the length of the header affects the line numbers in a golden file.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258941: Test specify the Classpath exception in the header

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/69/head:pull/69
$ git checkout pull/69

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 24, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Dec 24, 2020
Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 24, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258941: Test specify the Classpath exception in the header

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • c398a82: 8258916: javac/doclint reports broken HTML on multiline mailto links
  • 23b83c5: 8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov
  • 8b37c2c: 8257468: runtime/whitebox/TestWBDeflateIdleMonitors.java fails with Monitor should be deflated.: expected true to equal false
  • 9cd8e38: 8257521: runtime/logging/MonitorInflationTest.java crashed in MonitorList::unlink_deflated
  • 61e5e39: 8258832: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux-X64
  • eabc903: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows
  • 88dd6a9: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java
  • 772addf: 8258790: C2: Crash on empty macro node list

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 24, 2020
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 24, 2020

/integrate

@openjdk openjdk bot closed this Dec 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@jonathan-gibbons Since your change was applied there have been 8 commits pushed to the master branch:

  • c398a82: 8258916: javac/doclint reports broken HTML on multiline mailto links
  • 23b83c5: 8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov
  • 8b37c2c: 8257468: runtime/whitebox/TestWBDeflateIdleMonitors.java fails with Monitor should be deflated.: expected true to equal false
  • 9cd8e38: 8257521: runtime/logging/MonitorInflationTest.java crashed in MonitorList::unlink_deflated
  • 61e5e39: 8258832: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux-X64
  • eabc903: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows
  • 88dd6a9: 8258802: ProblemList TestJstatdDefaults.java, TestJstatdRmiPort.java, and TestJstatdServer.java
  • 772addf: 8258790: C2: Crash on empty macro node list

Your commit was automatically rebased without conflicts.

Pushed as commit e2aa724.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler integrated
2 participants