Skip to content
This repository has been archived by the owner. It is now read-only.

8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size #73

Closed

Conversation

@ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Dec 30, 2020

Scale the slice start index per carrier width, for views of direct byte buffers. This never worked correctly since being added in Java 13.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/73/head:pull/73
$ git checkout pull/73

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 30, 2020

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 30, 2020

@ChrisHegarty The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the nio label Dec 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 30, 2020

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 1, 2021

@ChrisHegarty Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

  • /reviewer credit @openjdk-bot
  • /reviewer credit duke
  • /reviewer credit @user1 @user2

Loading

@ChrisHegarty
Copy link
Member Author

@ChrisHegarty ChrisHegarty commented Jan 1, 2021

/reviewer credit alanb

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 1, 2021

@ChrisHegarty
Reviewer alanb successfully credited.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 2, 2021

@ChrisHegarty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 2, 2021
@ChrisHegarty
Copy link
Member Author

@ChrisHegarty ChrisHegarty commented Jan 2, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 2, 2021

@ChrisHegarty Pushed as commit 73f5415.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants