8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert

[Wanghuang-Huawei]

$java --add-modules=jdk.incubator.vector -Xcomp -XX:CompileCommand=compileonly,TestCast16BTo2D::* -XX:+UnlockDiagnosticVMOptions -XX:+PrintIntrinsics TestCast16BTo2D
before fixing:
  ** not supported: arity=1 op=cast/5 vlen2=2 etype1=byte ismask=0
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                      @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
                                      @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                    @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
                                      @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) failed to inline (intrinsic)
                                @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)
Expect:
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                      @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
                                      @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                    @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
                                      @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) (intrinsic)
                                @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Contributors

• He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/74/head:pull/74
$ git checkout pull/74

[bridgekeeper]

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[Wanghuang-Huawei]

/contributor add He Xuejin hexuejin2@huawei.com

[openjdk]

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

[openjdk]

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (705d908)

[iwanowww]

Looks good.

[openjdk]

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert

Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Reviewed-by: vlivanov, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• d529306: 8213032: program fails with LambdaConversionException at execution time
• 50bf433: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation
• b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
• bbc2e95: 8257906: JFR: RecordingStream leaks memory
• 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure
• 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier
• 216c2ec: 8258703: Incorrect 512-bit vector registers restore on x86_32
• 73f5415: 8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size
• 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TobiHartmann]

Looks good to me too.

[Wanghuang-Huawei]

/integrate

[openjdk]

@Wanghuang-Huawei
Your change (at version 705d908) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

@RealFYang @Wanghuang-Huawei Since your change was applied there have been 9 commits pushed to the master branch:

• d529306: 8213032: program fails with LambdaConversionException at execution time
• 50bf433: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation
• b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
• bbc2e95: 8257906: JFR: RecordingStream leaks memory
• 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure
• 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier
• 216c2ec: 8258703: Incorrect 512-bit vector registers restore on x86_32
• 73f5415: 8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size
• 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Your commit was automatically rebased without conflicts.

Pushed as commit 554e60c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.