Skip to content
This repository has been archived by the owner. It is now read-only.

8259043: More Zero architectures need linkage with libatomic #76

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 4, 2021

JDK-8256831 added the Zero linkage with libatomic for MIPS, but there are other 32-bit Zero platforms that need the same kind of treatment.

Additional testing:

  • linux-mipsel-zero-fastdebug build

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259043: More Zero architectures need linkage with libatomic

Reviewers

Contributors

  • Matthias Klose <doko@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/76/head:pull/76
$ git checkout pull/76

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Jan 4, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 4, 2021

/contributor add doko

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@shipilev
Contributor Matthias Klose <doko@openjdk.org> successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 4, 2021

Webrevs

Loading

erikj79
erikj79 approved these changes Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259043: More Zero architectures need linkage with libatomic

Co-authored-by: Matthias Klose <doko@openjdk.org>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 4, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jan 11, 2021

Matthias reports (privately) that Zero arches still build in Debian with this patch. Integrating.

/integrate

Loading

@openjdk openjdk bot closed this Jan 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@shipilev Since your change was applied there have been 24 commits pushed to the master branch:

  • 020ec84: 8259429: Update reference to README.md
  • fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
  • 677802d: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
  • 1973fbe: 8039278: console.sh failed Automatically with exit code 1
  • acdd90b: 8258972: unexpected compilation error with generic sealed interface
  • c1fb521: 8259227: C2 crashes with SIGFPE due to a division that floats above its zero check
  • 484e23b: 8258657: Doc build is broken by use of new language features
  • 4a478b8: 8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in TestEvent count
  • 4f914e2: 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description
  • eef43be: 8251200: False positive messages about missing comments for serialization
  • ... and 14 more: https://git.openjdk.java.net/jdk16/compare/73f5415363232804bd1904c1a80b0a724eabe63f...master

Your commit was automatically rebased without conflicts.

Pushed as commit e05f36f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants