Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16 Public archive

8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend #77

Closed

Conversation

Wanghuang-Huawei
Copy link

@Wanghuang-Huawei Wanghuang-Huawei commented Jan 4, 2021

For instace: in the implentation of VectorMaskCmp & VectorStoreMask :

$jtreg -vmoptions:"-XX:+PrintAssembly" ./Int128VectorTests.java

before fixing

0dc ldrq V17,[R10, #16] # vector (128 bits)
0e0 cmeq V16, V16, V17 # vector cmp (4I)
0e4 xtn V16, V16 # 4S to 4H
xtn V16, V16 # 4H to 4B
negr V16, V16 # store mask (4S to 4B)

Here, the output lacks data type qualifiers like T4S in cmeq V16, V16, V17.

Expect:

0dc ldrq V16,[R10, #16] # vector (128 bits)
0e0 cmeq V16, T4S, V16, V18 # vector cmp (4I)
0e4 xtn V16, T4H, V16, T4S # 4S to 4H
xtn V16, T8B, V16, T8H # 4H to 4B
negr V16, T8B, V16 # store mask (4S to 4B)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend

Contributors

  • He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/77/head:pull/77
$ git checkout pull/77

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.java.net label Jan 4, 2021
@Wanghuang-Huawei Wanghuang-Huawei changed the title JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend 8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend Jan 4, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2021

Webrevs

@Wanghuang-Huawei
Copy link
Author

/contributor add He Xuejin hexuejin2@huawei.com

@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@nsjian
Copy link

nsjian commented Jan 5, 2021

This looks good to me. But should this P4 enhancement go to https://github.com/openjdk/jdk instead of here?

@Wanghuang-Huawei
Copy link
Author

This looks good to me. But should this P4 enhancement go to https://github.com/openjdk/jdk instead of here?

OK. I will post a PR against jdk/jdk ASAP.

@Wanghuang-Huawei
Copy link
Author

I have posted a new PR against jdk/jdk: openjdk/jdk#1941

please close this PR. Thank you. @nsjian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.java.net rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants