Skip to content
This repository has been archived by the owner. It is now read-only.

8259213: Vector conversion with part > 0 is not getting intrinsic implementation #79

Closed
wants to merge 2 commits into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Jan 5, 2021

Vector conversion with part > 0 is implemented using slice(origin, vector) instead of slice(origin).
The slice(origin) has intrinsic implementation whereas slice(origin, vector) doesn’t.
Slice(origin) is written using vector API methods like rearrange and blend which all have intrinsic implementations.
Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange checkIndexes.

Please review this patch which fixes the above issue.

Best Regards,
Sandhya


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259213: Vector conversion with part > 0 is not getting intrinsic implementation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/79/head:pull/79
$ git checkout pull/79

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 5, 2021

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@sviswa7 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Jan 5, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@sviswa7
The core-libs label was successfully added.

@sviswa7 sviswa7 marked this pull request as ready for review Jan 5, 2021
@openjdk openjdk bot added the rfr label Jan 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 5, 2021

Webrevs

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Jan 5, 2021

/label hotspot

@openjdk openjdk bot added the hotspot label Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@sviswa7
The hotspot label was successfully added.

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Looks good. Can you please update the copyright year before integrating?

I notice the issue is not assigned to you, unsure of Skara will make it so once integrated.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259213: Vector conversion with part > 0 is not getting intrinsic implementation

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
  • bbc2e95: 8257906: JFR: RecordingStream leaks memory
  • 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure
  • 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier
  • 216c2ec: 8258703: Incorrect 512-bit vector registers restore on x86_32

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 5, 2021
@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Jan 5, 2021

@PaulSandoz Thanks a lot for the review. I have updated the copyright year. Please let me know if I can go ahead and integrate.

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Jan 5, 2021

@PaulSandoz Thanks a lot for the review. I have updated the copyright year. Please let me know if I can go ahead and integrate.

All good.

@sviswa7
Copy link
Author

@sviswa7 sviswa7 commented Jan 5, 2021

/integrate

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@sviswa7 Since your change was applied there have been 5 commits pushed to the master branch:

  • b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
  • bbc2e95: 8257906: JFR: RecordingStream leaks memory
  • 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure
  • 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier
  • 216c2ec: 8258703: Incorrect 512-bit vector registers restore on x86_32

Your commit was automatically rebased without conflicts.

Pushed as commit 50bf433.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs hotspot integrated
2 participants