Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257906: JFR: RecordingStream leaks memory #81

Closed
wants to merge 1 commit into from
Closed

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Jan 5, 2021

Backport of JDK-8258478: JFR: RecordingStream leaks memory


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/81/head:pull/81
$ git checkout pull/81

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 5, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c6648501589bf36945340cb1e82c833ebd7485d 8257906: JFR: RecordingStream leaks memory Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257906: JFR: RecordingStream leaks memory

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Jan 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 5, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Looks good.

@egahlin
Copy link
Member Author

@egahlin egahlin commented Jan 5, 2021

/integrate

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@egahlin Since your change was applied there have been 2 commits pushed to the master branch:

  • 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure
  • 4ffbe84: 8256266: Binding variables don't correctly support declaration annotations and the final modifier

Your commit was automatically rebased without conflicts.

Pushed as commit bbc2e95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants