Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes #82

Closed
wants to merge 1 commit into from

Conversation

raphw
Copy link
Member

@raphw raphw commented Jan 5, 2021

This change avoid that owner types of static nested classes are returned as parameterized types.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/82/head:pull/82
$ git checkout pull/82

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2021

👋 Welcome back winterhalter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2021
@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@raphw The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.java.net label Jan 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@raphw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes

Reviewed-by: jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 80110da: 8259007: This test printed a blank page
  • 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
  • d529306: 8213032: program fails with LambdaConversionException at execution time
  • 50bf433: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation
  • b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
  • bbc2e95: 8257906: JFR: RecordingStream leaks memory
  • 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2021
@raphw
Copy link
Member Author

raphw commented Jan 6, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@raphw
Your change (at version 54a9447) is now ready to be sponsored by a Committer.

@jbf
Copy link
Member

jbf commented Jan 6, 2021

/sponsor

@openjdk openjdk bot closed this Jan 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@jbf @raphw Since your change was applied there have been 9 commits pushed to the master branch:

  • ad45678: 8258558: Revert changes for JDK-8252505 and related issues
  • e66187d: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition
  • 80110da: 8259007: This test printed a blank page
  • 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
  • d529306: 8213032: program fails with LambdaConversionException at execution time
  • 50bf433: 8259213: Vector conversion with part > 0 is not getting intrinsic implementation
  • b7940aa: 8259027: NullPointerException in makeMappedSegment due to NULL Unmapper when length of segment is 0
  • bbc2e95: 8257906: JFR: RecordingStream leaks memory
  • 6775113: 8258393: Shenandoah: "graph should be schedulable" assert failure

Your commit was automatically rebased without conflicts.

Pushed as commit d25a1be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs core-libs-dev@openjdk.java.net integrated Pull request has been integrated
2 participants