Skip to content
This repository has been archived by the owner. It is now read-only.

8258558: Revert changes for JDK-8252505 and related issues #86

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jan 5, 2021

As the result of retroactive CSR discussion in JDK-8257827, I have decided to revert the original push and all the follow-up changes from JDK 16, in order to reconsider them for JDK 17.

This PR reverts the following changes -- the reversal is clean and done without manual intervention:
JDK-8258111: Problemlist compiler/blackhole tests for -Xcomp until JDK-8258101 is fixed
JDK-8257848: -XX:CompileCommand=blackhole,* should be diagnostic
JDK-8257805: Add compiler/blackhole tests to tier1
JDK-8257803: Add -Xbatch to compiler/blackhole tests
JDK-8252505: C1/C2 compiler support for blackholes

While line count is great, the overwhelming majority of changes are test removals.

Additional testing:

  • Linux x86_64 tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258558: Revert changes for JDK-8252505 and related issues

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/86/head:pull/86
$ git checkout pull/86

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 5, 2021
@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jan 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2021

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258558: Revert changes for JDK-8252505 and related issues

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 5, 2021
@shipilev
Copy link
Contributor Author

shipilev commented Jan 6, 2021

/integrate

@openjdk openjdk bot added the integrated label Jan 6, 2021
@openjdk openjdk bot closed this Jan 6, 2021
@openjdk openjdk bot removed ready rfr labels Jan 6, 2021
@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@shipilev Since your change was applied there have been 4 commits pushed to the master branch:

  • e66187d: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition
  • 80110da: 8259007: This test printed a blank page
  • 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
  • d529306: 8213032: program fails with LambdaConversionException at execution time

Your commit was automatically rebased without conflicts.

Pushed as commit ad45678.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot integrated
2 participants