Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in TestEvent count #87

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jan 5, 2021

Hi,

Could I have review of a test fix?

Tests fails intermittently, most likely due to JFR not able to keep up with the high event rate. Purpose of the test is not to stress JFR, so events are now only emitted from one thread. I also changed the assert, so it is easier to see how much off the count is.

Tested by running it 100 times without failure.

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in TestEvent count

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/87/head:pull/87
$ git checkout pull/87

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.java.net label Jan 5, 2021
@egahlin egahlin marked this pull request as ready for review January 5, 2021 20:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2021

Webrevs

@@ -38,9 +38,7 @@
// Java agent that emits in multiple threads
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@openjdk
Copy link

openjdk bot commented Jan 6, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in TestEvent count

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 4f914e2: 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description
  • eef43be: 8251200: False positive messages about missing comments for serialization
  • f1bc4e0: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 4a5786b: 8259075: Update the copyright notice in the files generated by CLDR Converter tool
  • d25a1be: 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes
  • ad45678: 8258558: Revert changes for JDK-8252505 and related issues
  • e66187d: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition
  • 80110da: 8259007: This test printed a blank page
  • 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
  • d529306: 8213032: program fails with LambdaConversionException at execution time
  • ... and 2 more: https://git.openjdk.java.net/jdk16/compare/bbc2e9510bb32d69d823bd572b6c0c02bd2335af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2021
@egahlin
Copy link
Member Author

egahlin commented Jan 7, 2021

/integrate

@openjdk openjdk bot closed this Jan 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2021
@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@egahlin Since your change was applied there have been 12 commits pushed to the master branch:

  • 4f914e2: 8249633: doclint reports missing javadoc for JavaFX property methods that have a property description
  • eef43be: 8251200: False positive messages about missing comments for serialization
  • f1bc4e0: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 4a5786b: 8259075: Update the copyright notice in the files generated by CLDR Converter tool
  • d25a1be: 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of statically nested classes
  • ad45678: 8258558: Revert changes for JDK-8252505 and related issues
  • e66187d: 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores Unmapper#pagePosition
  • 80110da: 8259007: This test printed a blank page
  • 554e60c: 8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert
  • d529306: 8213032: program fails with LambdaConversionException at execution time
  • ... and 2 more: https://git.openjdk.java.net/jdk16/compare/bbc2e9510bb32d69d823bd572b6c0c02bd2335af...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4a478b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.java.net integrated Pull request has been integrated
2 participants