8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in TestEvent count #87
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
Webrevs
|
@@ -38,9 +38,7 @@ | |||
// Java agent that emits in multiple threads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@egahlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@egahlin Since your change was applied there have been 12 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4a478b8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Could I have review of a test fix?
Tests fails intermittently, most likely due to JFR not able to keep up with the high event rate. Purpose of the test is not to stress JFR, so events are now only emitted from one thread. I also changed the assert, so it is easier to see how much off the count is.
Tested by running it 100 times without failure.
Thanks
Erik
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk16 pull/87/head:pull/87
$ git checkout pull/87