Skip to content
This repository has been archived by the owner. It is now read-only.

8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win) #96

Closed

Conversation

@Michael-Mc-Mahon
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon commented Jan 8, 2021

Continuing this review on a new PR (for jdk16). I have also updated the implementation to use VerifyVersionInfo.

Thanks,
Michael


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/96/head:pull/96
$ git checkout pull/96

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 8, 2021

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Jan 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 8, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 8, 2021
@Michael-Mc-Mahon
Copy link
Member Author

@Michael-Mc-Mahon Michael-Mc-Mahon commented Jan 8, 2021

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@Michael-Mc-Mahon Pushed as commit fb68395.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants