Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258909: update jdk16u jcheck conf #1

Closed
wants to merge 1 commit into from

Conversation

@robm-openjdk
Copy link
Member

@robm-openjdk robm-openjdk commented Dec 23, 2020

The jdk16u repository is forked from the jdk16 stabilization repository. The jcheck configuration should be updated post-fork to indicate that this repository is part of the jdk-updates project.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/1/head:pull/1
$ git checkout pull/1

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2020

👋 Welcome back robm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2020

Webrevs

Loading

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@robm-openjdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258909: update jdk16u jcheck conf

Reviewed-by: kcr, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 23, 2020
@robm-openjdk
Copy link
Member Author

@robm-openjdk robm-openjdk commented Dec 24, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@robm-openjdk Pushed as commit be345a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants