Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262295: C2: Out-of-Bounds Array Load from Clone Source #101

Conversation

@reinrich
Copy link
Contributor

@reinrich reinrich commented Apr 1, 2021

This is the jdk16u backport of the fix for JDK-8262295.
The fix applies cleanly.
The test required trivial adaptation: I had to remove the package from the class ClassFileInstaller.

The fix passed our CI testing: JCK and JTREG, also in Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite,
SAP specific tests with fastdebug and release builds on all platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262295: C2: Out-of-Bounds Array Load from Clone Source

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/101/head:pull/101
$ git checkout pull/101

Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.java.net/jdk16u pull/101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 101

View PR using the GUI difftool:
$ git pr show -t 101

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/101.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 1, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@reinrich reinrich changed the title Backport of 8262295: C2: Out-of-Bounds Array Load from Clone Source. 8262295: C2: Out-of-Bounds Array Load from Clone Source. Apr 1, 2021
@reinrich reinrich changed the title 8262295: C2: Out-of-Bounds Array Load from Clone Source. 8262295: C2: Out-of-Bounds Array Load from Clone Source Apr 1, 2021
@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 1, 2021

Hi Rich, I had issues with non clean backports as well...

To get this accepted by the bots, try to set the PR title to "Backport of 9689863ac0bac8c542162d4af30fec078e9c91b4".

If that doesn't help, you need to manipulate your git commit message that way...

@reinrich reinrich changed the title 8262295: C2: Out-of-Bounds Array Load from Clone Source Backport of 9689863ac0bac8c542162d4af30fec078e9c91b4 Apr 1, 2021
@reinrich reinrich changed the title Backport of 9689863ac0bac8c542162d4af30fec078e9c91b4 8262295: C2: Out-of-Bounds Array Load from Clone Source Apr 1, 2021
@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Apr 1, 2021

Hi Rich, I had issues with non clean backports as well...

Hi Christoph,
I wasn't even aware that there are still issues (besides the message "Issue is not open").

To get this accepted by the bots, try to set the PR title to "Backport of 9689863ac0bac8c542162d4af30fec078e9c91b4".

I've done that now. jcheck complained about the commit message.

Now I changed the title back again to :
jcheck succeeds with this. Do you still see issues?

If that doesn't help, you need to manipulate your git commit message that way...

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 1, 2021

Hi Rich, I had issues with non clean backports as well...

Hi Christoph,
I wasn't even aware that there are still issues (besides the message "Issue is not open").

To get this accepted by the bots, try to set the PR title to "Backport of 9689863ac0bac8c542162d4af30fec078e9c91b4".

I've done that now. jcheck complained about the commit message.

Now I changed the title back again to :
jcheck succeeds with this. Do you still see issues?

If that doesn't help, you need to manipulate your git commit message that way...

Ah, I didn't see that the PR was still in draft. Let's see what happens when you open it...

@reinrich reinrich marked this pull request as ready for review Apr 8, 2021
@openjdk openjdk bot added the rfr label Apr 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Webrevs

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Apr 8, 2021

/label backport

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@reinrich The label backport is not a valid label. These labels are valid:

@reinrich reinrich changed the title 8262295: C2: Out-of-Bounds Array Load from Clone Source Backport 9689863ac0bac8c542162d4af30fec078e9c91b4 Apr 9, 2021
@openjdk openjdk bot changed the title Backport 9689863ac0bac8c542162d4af30fec078e9c91b4 8262295: C2: Out-of-Bounds Array Load from Clone Source Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262295: C2: Out-of-Bounds Array Load from Clone Source

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 048040f: 8264374: Shenandoah: Remove leftover parallel reference processing argument
  • 426cb6a: 8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true
  • 27c8449: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 12, 2021
@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Apr 12, 2021

Thanks for the review @TobiHartmann

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Apr 14, 2021

/integrate

@openjdk openjdk bot closed this Apr 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@reinrich Since your change was applied there have been 5 commits pushed to the master branch:

  • 2826d30: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 4f5421e: 8262110: DST starts from incorrect time in 2038
  • 048040f: 8264374: Shenandoah: Remove leftover parallel reference processing argument
  • 426cb6a: 8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true
  • 27c8449: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl

Your commit was automatically rebased without conflicts.

Pushed as commit 8ddb1d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants